Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deps] Remove Python workaround in LLVM build, no longer necessary #45176

Merged
merged 1 commit into from
May 4, 2022

Conversation

giordano
Copy link
Contributor

@giordano giordano commented May 3, 2022

According to @vchuravy in #45128 (comment), using Python 2 for building LLVM may not be necessary anymore. Also, macOS 12.3+ doesn't even come with Python 2, causing a failure in a from source build of LLVM. @fxcoudert would you be able to test this?

Should fix #45128

@giordano giordano added building Build system, or building Julia or its dependencies system:mac Affects only macOS external dependencies Involves LLVM, OpenBLAS, or other linked libraries labels May 3, 2022
@giordano giordano requested a review from vtjnash May 3, 2022 23:03
@giordano giordano added the backport 1.8 Change should be backported to release-1.8 label May 3, 2022
@fxcoudert
Copy link
Contributor

The patch applies, silences the error message report in #45128 on macOS 12.3.1
Build is otherwise unaffected, so looking good.

@vchuravy vchuravy merged commit 862018b into JuliaLang:master May 4, 2022
@giordano giordano deleted the mg/llvm-python-workaround branch May 4, 2022 15:57
KristofferC pushed a commit that referenced this pull request May 16, 2022
@KristofferC KristofferC mentioned this pull request May 16, 2022
67 tasks
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies external dependencies Involves LLVM, OpenBLAS, or other linked libraries system:mac Affects only macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS ≥ 12.3 does not have python anymore
5 participants