docs: print extra information when deploying #46030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticfloat
approved these changes
Jul 13, 2022
ffucci
pushed a commit
to ffucci/julia
that referenced
this pull request
Aug 11, 2022
pcjentsch
pushed a commit
to pcjentsch/julia
that referenced
this pull request
Aug 18, 2022
mortenpi
added
docsystem
KristofferC
pushed a commit
that referenced
this pull request
Sep 7, 2022
(cherry picked from commit b3b229e)
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly to print out a little bit of information why deployment doesn't happen. Currently, if the deploy config sets
all_ok=false, then the wholedeploydocscall will be completely silent. Should help us debug the current Buildkite failure.It also makes the
deploydocscall conditional ondeployargument being passed, which I think is good idea since we're relying less on various CI variables telling us that whether we should deploy or not than we used to. Basically, I believe right now, if you setDOCUMENTER_KEY,deploydocsmight try to do something, even if you're just building docs locally.cc @staticfloat, @fredrikekre