Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Dates.argerror #46031

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Deprecate Dates.argerror #46031

merged 2 commits into from
Aug 30, 2022

Conversation

LilithHafner
Copy link
Member

I don't see what this function does besides adding a layer of indirection to stack traces and code analysis.

@LilithHafner LilithHafner added dates Dates, times, and the Dates stdlib module deprecation This change introduces or involves a deprecation labels Jul 13, 2022
@KristofferC KristofferC merged commit 909f153 into JuliaLang:master Aug 30, 2022
@LilithHafner LilithHafner deleted the deprecate-argerror branch August 30, 2022 15:25
@omus
Copy link
Member

omus commented Nov 25, 2022

I don't see what this function does besides adding a layer of indirection to stack traces and code analysis.

In the pre-1.0 days this function ended up using Nullable so it did have a point. Should have probably been corrected when Nullable was removed (#23642) but that was a pretty hefty PR so I can see how it was missed.

@omus omus mentioned this pull request Nov 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredrikekre fredrikekre fredrikekre left review comments

Assignees
No one assigned
Labels
dates Dates, times, and the Dates stdlib module deprecation This change introduces or involves a deprecation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LilithHafner @omus @fredrikekre @KristofferC