Darwin: use libgcc_s version 1.1 on all targets #46240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Hum, is the compiler used in the pre-built CSL not recent enough? |
|
|
OK, after checking this needs GCC 12. So this will need #45582 to be merged before re-testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libgcc support shared library on modern GCC versions (11 and later) is called
libgcc_s.1.1.dylibon all Darwin platforms. While alibgcc_s.1.dylibis still provided for backward compatibility on Intel Darwin, it is not recommended to use it.On aarch64-darwin,
libgcc_s.1.dylibis not provided at all, which is why this was special-cased in the build system. But actually, linking againstlibgcc_s.1.1.dylibin all cases on Darwin is the right way to go.