Disable some FileWatching tests on x86_64 apple #46384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Red #46185, right? |
|
Hopefully yeah |
Keno
approved these changes
Aug 17, 2022
Keno
reviewed
Aug 18, 2022
| while changes[end][1] == F_PATH * "~" | ||
| @test pop!(changes)[2] == FileWatching.FileEvent(FileWatching.UV_RENAME) | ||
|
|
||
| if !((Sys.ARCH == :x86_64) && (Sys.isapple())) #These tests tend to fail a lot on x86-apple |
There was a problem hiding this comment.
Whoops, I may have been a little overeager. These fail on aarch64 also, so should be disabled everywhere.
There was a problem hiding this comment.
I actually haven't seen this fail in FileWatching in aarch64, the only one I've seen was a failure in the PIDFile test.
There was a problem hiding this comment.
Ok, but the moment we see it, the test is gone ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macos does some weird event reordoring which means these tests fail often polluting CI output