Disable even more FileWatching tests #46497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to still fail in FileWatching on mac |
DilumAluthge
force-pushed
the
disable-more-tests
branch
from
2ce9274
to
393bd6a
Compare
gbaraldi
force-pushed
the
disable-more-tests
branch
from
393bd6a
to
24ba685
Compare
DilumAluthge
force-pushed
the
disable-more-tests
branch
from
75b554a
to
5d15b9f
Compare
KristofferC
reviewed
Aug 30, 2022
stdlib/FileWatching/test/runtests.jl
Outdated
| @@ -32,7 +35,9 @@ for i in 1:n | |||
| if !fd_in_limits && Sys.islinux() | |||
| run(`ls -la /proc/$(getpid())/fd`) | |||
| end | |||
| @test fd_in_limits | |||
| if ismacos_arm | |||
There was a problem hiding this comment.
Should this be !ismacos_arm? Does this test really only work on macOS ARM?
There was a problem hiding this comment.
Yeah, that was a typo. :-/
KristofferC
approved these changes
Aug 30, 2022
giordano
reviewed
Aug 30, 2022
Comment on lines
+37
to
+39
| if !ismacos_arm | ||
| @test fd_in_limits | ||
| end |
There was a problem hiding this comment.
Can also use
@test fd_in_limits skip=ismacos_armwhich marks the test as broken, which I guess is a useful reminder
There was a problem hiding this comment.
Those tests are probably never going to be reliable on macos anyhow, I guess setting them as broken is cleaner. Not sure
DilumAluthge
force-pushed
the
disable-more-tests
branch
from
8ce124f
to
3fd65e0
Compare
|
I'm not particularly happy with the x86 vs aarch64 difference. These are mac kernel differences, not architecture specific issues. Either we expect the macos system to have these invariants or not. It shouldn't be platform specific. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are also unreliable so disable them too for now. See #46185