audit inbounds for arrays #46911
Draft
audit inbounds for arrays #46911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove some unnecessary and incorrect inbounds annotations. Fix #46879
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. |
JeffBezanson
approved these changes
Sep 29, 2022
vtjnash
added
DO NOT MERGE
vtjnash
commented
Jan 19, 2023
| while true | ||
| y = iterate(itr, st) | ||
| y === nothing && break | ||
| el, st = y | ||
| @assert len == length(dest) | ||
| if el isa T | ||
| @inbounds dest[i] = el |
There was a problem hiding this comment.
@aviatesk could we make this @inbounds conditional on iterate(itr, st) being pure and inlined (e.g. a simple load or computation)? That is the only case where this might SIMD, and thus the main case where we might care to eliminate the check here.
(We would like to check also if the user miscomputed length(itr) also and so this ran too many or too few iterations, but that seems harder)
|
This seems like a good PR to get merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some unnecessary and incorrect inbounds annotations.
Fix #46879
@nanosoldier
runbenchmarks(!"scalar" && !"union", vs=":master")