Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[InteractiveUtils] win: handle empty clipboard errors #47311

Merged
merged 1 commit into from
Oct 24, 2022
Merged

[InteractiveUtils] win: handle empty clipboard errors #47311

merged 1 commit into from
Oct 24, 2022

Conversation

vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented Oct 24, 2022

Fix #46981

@giordano giordano added the system:windows Affects only Windows label Oct 24, 2022
@DilumAluthge DilumAluthge added bugfix This change fixes an existing bug backport 1.8 Change should be backported to release-1.8 labels Oct 24, 2022
@vtjnash
Copy link
Sponsor Member Author

vtjnash commented Oct 24, 2022

Windows is all green now with this. Almost all CI is green in fact. Just the Pkg SHA1 bug seems to be remaining!

@vchuravy vchuravy merged commit 0645427 into master Oct 24, 2022
@vchuravy vchuravy deleted the jn/46981 branch October 24, 2022 19:38
@LilithHafner
Copy link
Member

Do we have any confirmation that these error codes are only used when the clipboard is empty?

This PR also makes it so that we do error when cause === :GetClipboardData && errno == 0. Was that change intentional?

@vtjnash
Copy link
Sponsor Member Author

vtjnash commented Oct 25, 2022

Yes, this only gets called when the clipboard failed

KristofferC pushed a commit that referenced this pull request Oct 27, 2022
@vtjnash
[InteractiveUtils] win: handle empty clipboard errors (#47311)
f2f579a 
Fix #46981

(cherry picked from commit 0645427)
@KristofferC KristofferC mentioned this pull request Oct 27, 2022
Merged
37 tasks
KristofferC pushed a commit that referenced this pull request Oct 28, 2022
@vtjnash @KristofferC
[InteractiveUtils] win: handle empty clipboard errors (#47311)
b8ab6cf 
Fix #46981

(cherry picked from commit 0645427)
@KristofferC KristofferC removed the backport 1.8 Change should be backported to release-1.8 label Nov 8, 2022
@MarcMush MarcMush mentioned this pull request Dec 16, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix This change fixes an existing bug system:windows Affects only Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GetClipboardData() fails on buildkite windows CI
6 participants
@vtjnash @LilithHafner @vchuravy @giordano @KristofferC @DilumAluthge