Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Windows CI on buildkite on release-1.8 #47394

Closed
wants to merge 2 commits into from
Closed

Conversation

KristofferC
Copy link
Sponsor Member

To see if the Windows red in #46984 is due to the stuff in there or due to moving Windows CI to buildkite.

@KristofferC KristofferC added the DO NOT MERGE Do not merge this PR! label Oct 31, 2022
…2` from the list (#46997)

(cherry picked from commit 6424f79)
(cherry picked from commit 431b19b)
@DilumAluthge
Copy link
Member

Windows Buildkite is green on master (or, rather, it was green until very recently), so if there's a test failure on 1.8, it probably means that we forgot to backport something.

@staticfloat

@KristofferC
Copy link
Sponsor Member Author

Windows doesn't even seem to build here...

@DilumAluthge
Copy link
Member

Yeah, I suspect it needs some patches that are currently waiting in the backport branch.

Are you trying to get 1.8.3 ready? If so, maybe we should bring the Windows Buildbots back up again. And then we can figure out Windows Buildkite for 1.8.4.

@KristofferC
Copy link
Sponsor Member Author

Are you trying to get 1.8.3 ready

Yes,

If so, maybe we should bring the Windows Buildbots back up again. And then we can figure out Windows Buildkite for 1.8.4.

Works for me.

@DilumAluthge DilumAluthge deleted the kc/ci_test branch November 13, 2022 19:37
@DilumAluthge DilumAluthge removed the DO NOT MERGE Do not merge this PR! label Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants