cgmemmgr,macos: add missing shared_map_lock initialization #47419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
system:mac
|
LGTM, but I don't get why this is tagged as mac. Is mutex initialization different in mac than linux? |
|
It was initialized on |
|
I can confirm that the fix here resolve the crash I saw in #47254 (comment). |
quinnj
approved these changes
Nov 2, 2022
|
As one more note of context: in the Relational AI workflow where we saw the crash, we ended up triggering this code path from a very long-running application that eventually genned enough code to need an additional shared page and on macos, this wasn't being initialized properly. |
|
@vchuravy, squash please :) |
26 tasks
78 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47254