Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast path constants in update_julia_type only if correct type #47480

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Fast path constants in update_julia_type only if correct type #47480

merged 2 commits into from
Nov 8, 2022

Conversation

apaz-cli
Copy link
Member

@apaz-cli apaz-cli commented Nov 7, 2022

Fixes #47247

vtjnash
vtjnash reviewed Nov 7, 2022
View reviewed changes
test/compiler/codegen.jl Outdated Show resolved Hide resolved
vtjnash
vtjnash reviewed Nov 7, 2022
View reviewed changes
test/compiler/codegen.jl Outdated Show resolved Hide resolved
@vtjnash vtjnash added the merge me PR is reviewed. Merge when all tests are passing label Nov 8, 2022
@KristofferC KristofferC merged commit dad08f2 into JuliaLang:master Nov 8, 2022
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assertion Order == AtomicOrdering::NotAtomic && !isboxed && rhs.typ == jltype fails on some packages
4 participants
@apaz-cli @vtjnash @KristofferC @DilumAluthge