Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #47662, broken --compile=all on 1.8.x #47678

Merged
merged 1 commit into from
Dec 2, 2022
Merged

fix #47662, broken --compile=all on 1.8.x #47678

merged 1 commit into from
Dec 2, 2022

Conversation

JeffBezanson
Copy link
Sponsor Member

fix #47662

@DilumAluthge
Copy link
Member

DilumAluthge commented Nov 23, 2022 •
edited
Loading

I think that this should target the backports-release-1.8 branch instead, right?

@DilumAluthge DilumAluthge added bugfix This change fixes an existing bug release Release management and versioning. labels Nov 23, 2022
@vtjnash
Copy link
Sponsor Member

vtjnash commented Nov 23, 2022

The title of commits probably usually shouldn't have fix #### in it, since it makes it hard to fit in the 50-character limit for one-line showing and doesn't even hot-link in many places like it would if put into the commit message body

@JeffBezanson JeffBezanson changed the base branch from release-1.8 to backports-release-1.8 November 29, 2022 22:49
@JeffBezanson JeffBezanson merged commit 976be82 into backports-release-1.8 Dec 2, 2022
@JeffBezanson JeffBezanson deleted the jb/18compileall branch December 2, 2022 21:04
KristofferC pushed a commit that referenced this pull request Dec 14, 2022
@JeffBezanson
fix #47662, broken --compile=all on 1.8.x (#47678)
8abef03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix This change fixes an existing bug release Release management and versioning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeffBezanson @DilumAluthge @vtjnash