Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subtype: avoid some false alarm in subtype_unionall #47868

Closed
wants to merge 3 commits into from
Closed

Subtype: avoid some false alarm in subtype_unionall #47868

wants to merge 3 commits into from

Commits on Dec 16, 2022

  1. Subtype: avoid some false alarm in subtype_unionall 

    The current check is not correct if we set the typevar's bounds to an unwrapped `UnionAll`. Use `var_occurs_inside_skip` to skip the inside check.
    @N5N3
    N5N3 committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    b5f7982 View commit details
    Browse the repository at this point in the history

  2. Revert "Subtype: avoid some false alarm in subtype_unionall" 

    This reverts commit b5f7982.
    @N5N3
    N5N3 committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    dce29f8 View commit details
    Browse the repository at this point in the history

  3. Make sure UnionAll keeps wrapped when bounds setting. 

    Also add `env` test.
    @N5N3
    N5N3 committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    2bac38a View commit details
    Browse the repository at this point in the history