Add a test for task state cleanup when Task are unscheduled #47871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenhinkeller
added
test
quinnj
reviewed
Dec 12, 2022
| @@ -322,6 +322,19 @@ close(proc.in) | |||
| end | |||
| end | |||
|
|
|||
| @testset "threads clean up task local state" begin | |||
There was a problem hiding this comment.
Note that in my tests in WorkerUtilities.jl, I couldn't get the task.code= nothing solution to work when the tests were run inside a @testset; I did a little digging, but couldn't figure out what was going on there. Possibly something related to how @testsets use task-local-storage maybe?
There was a problem hiding this comment.
🤔 weirdly the tests passed here though, it seems?
|
@vchuravy: whatever solution you do end up with, can we try to incorporate this test case into it? I'll close this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:) I figured it was nicer to actually commit the test rather than just suggesting it in a code comment.
Merges into #47829.