Avoid allocations in reduction over adjoints #48120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
approved these changes
Jan 4, 2023
|
Should this be backported to v1.9? |
dkarrasch
added
backport 1.8
KristofferC
pushed a commit
that referenced
this pull request
Jan 10, 2023
(cherry picked from commit a9506f5)
41 tasks
KristofferC
pushed a commit
that referenced
this pull request
Feb 6, 2023
(cherry picked from commit a9506f5)
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the allocation part of #47703 as advised by @N5N3. Yields a major speedup, but doesn't quite reach the pre-46605 times for that specific size, though @N5N3 mentions that for other sizes the "new" approach is faster. So we may consider to close the issue with this fix?
Fixes #47703.