Always use -Wl,--warn-unresolved-symbols in MSAN builds
#48835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
added
building
|
I'm not sure I understand. |
I think MSAN builds (somewhat) work only on x86_64 linux. @gbaraldi is that correct? |
|
MSAN only exists on linux currently so yeah. |
|
Ok, according to the docs builds with sanitizer might work also on macOS. I change it to add % make SANITIZE=1 SANITIZE_MEMORY=1 print-SANITIZE_LDFLAGS
SANITIZE_LDFLAGS= -fsanitize=memory -fsanitize-memory-track-origins -fno-omit-frame-pointerwhich looks good. |
|
Sanitizers work on macos fine. Specifically ASAN and TSAN, but MSAN is Linux and some BSDs only. At least currently. But that looks fine. |
KristofferC
pushed a commit
that referenced
this pull request
Mar 3, 2023
* Always use `-Wl,--warn-unresolved-symbols` in MSAN builds * Use `-Wl,--warn-unresolved-symbols` only on Linux and FreeBSD (cherry picked from commit a07f512)
KristofferC
pushed a commit
that referenced
this pull request
Mar 3, 2023
* Always use `-Wl,--warn-unresolved-symbols` in MSAN builds * Use `-Wl,--warn-unresolved-symbols` only on Linux and FreeBSD (cherry picked from commit a07f512)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the two ways I could think of to fix #48732. The other one is to use
-Wl,--warn-unresolved-symbolsin suitesparse only when doing the MSAN build, but I figured that this flag might be useful for other packages as well.CC: @fxcoudert.