Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Emit unoptimized bitcode archive #50946

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

boomanaiden154
Copy link
Contributor

This patch adds in an environment variable that can be set to a directory where unoptimized bitcode (within an archive) should be emitted during package compilation.

This patch adds in an environment variable that can be set to a
directory where unoptimized bitcode (within an archive) should be
emitted during package compilation.
@boomanaiden154
Copy link
Contributor Author

@vchuravy

This gets us what we need based on what we discussed in our meeting a couple weeks ago. However, there are a couple points that I think probably need to be fixed before it's upstream ready:

  • Add this to a doc page somewhere? It's going to be a pretty esoteric option, but having information on it is probably good. I'm thinking the environment variables page should work?
  • Is having this option as an environment variable okay or is there a more preferred option? I mostly chose to use an environment variable as it was easy to implement.
  • Unit tests in /test/loading.jl?

Thank you so much for your assistance with all of this!

@boomanaiden154 boomanaiden154 marked this pull request as draft August 17, 2023 00:03
@boomanaiden154 boomanaiden154 marked this pull request as ready for review August 19, 2023 04:56
@brenhinkeller brenhinkeller added the compiler:codegen Generation of LLVM IR and native code label Aug 23, 2023
@vchuravy vchuravy self-requested a review August 25, 2023 22:18
@boomanaiden154
Copy link
Contributor Author

@vchuravy Do you mind taking a look at this when you have a chance and leeting me know what else needs to be done? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:codegen Generation of LLVM IR and native code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants