Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen: ensure i1 bool is widened to i8 before storing #52189

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Commits on Nov 16, 2023

  1. codegen: ensure i1 bool is widened to i8 before storing

    Teach value_to_pointer to convert primitive types to their stored
    representation first, to avoid exposing undef bits later (via memcpy).
    
    Take this opportunity to also generalizes the support for zext Bool to
    anywhere inside any struct for changing any bitwidth to a multiple of 8
    bytes. This would change a vector like <2 x i4> from occupying i8 to i16
    (c.f. LLVM's LangRef), if such an operation were expressible in Julia
    today. And take this opportunity to do a bit of code cleanup, now that
    codegen is better and using helpers from LLVM.
    
    Fixes #52127
    vtjnash committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    29b85e8 View commit details
    Browse the repository at this point in the history