Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add update mechanism for Terminfo, and common user-alias data #53285

Merged
merged 5 commits into from
Feb 23, 2024
Merged

Add update mechanism for Terminfo, and common user-alias data #53285

merged 5 commits into from
Feb 23, 2024

Commits on Feb 13, 2024

  1. Turn terminfo_data.jl into a self-updating quine 

    Is it brilliant or cursed? That's up for debate, but I think it's neat.

This change also revealed some minor discrepancies between the NCurses
source (which we use nwo) and the processed source I originally
used (from some python package? I can't quite recall).

All of the minor discrepancies are cosmetic, with the exception of:
- memory_below moving down by one, and
- backspace_with_bs changing to backspace_if_not_bs

Since we are now using NCurses's source directly, I'm inclined to trust
these changes.
    @tecosaur
    tecosaur committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    eabdd9c View commit details
    Browse the repository at this point in the history

  2. Switch the field ordering of TermCapability 

    The preferred code to use is the "long" symbol, for readability when
used. I think it makes sense to have it as the first field to reflect
that. While we're at it, we may as well update the field names to better
indicate that "short" is the actual capname, and just call "long"
"name".
    @tecosaur
    tecosaur committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    f49c193 View commit details
    Browse the repository at this point in the history

  3. Make aliases structurally distinct in TermInfo

    @tecosaur
    tecosaur committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    7782823 View commit details
    Browse the repository at this point in the history

  4. Add user-aliases to TermInfo

    @tecosaur
    tecosaur committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    003172d View commit details
    Browse the repository at this point in the history

  5. Change terminfo update logic, and update 

    Using the tagged releases in the ncurses repository isn't actually a
good idea, since it fails to capture the patch releases made
subsequently.

Instead, we switch to grabbing the latest version and recording which
patch release it is. Normally, there would be a danger of grabbing
un-released changes, however this doesn't seem like an actual risk in
this case given how the ncurses repo seems to operate.
    @tecosaur
    tecosaur committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    1a76ed4 View commit details
    Browse the repository at this point in the history