Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent tainting native code loading from propagating #53457

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Prevent tainting native code loading from propagating #53457

merged 2 commits into from
Feb 25, 2024

Commits on Feb 24, 2024

  1. Prevent tainting native code loading from propagating 

    When we use options like code coverage, we can't use the native code
present in the cache file since it is not instrumented.

PR #52123 introduced the capability of skipping the native
code during loading, but created the issue that subsequent packages
could have an explicit or implicit dependency on the native code.

PR #53439 tainted the current process by setting
`use_sysimage_native_code`, but this flag is propagated to subprocesses
and lead to a regression in test time.

Move this to a process local flag to avoid the regression.
In the future we might be able to change the calling convention for
cross-image calls to `invoke(ci::CodeInstance, args...)` instead of
`ci.fptr(args...)` to handle native code not being present.
    @vchuravy
    vchuravy committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    7ab8496 View commit details
    Browse the repository at this point in the history

  2. Update src/staticdata.c

    @vtjnash
    vtjnash authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    b386091 View commit details
    Browse the repository at this point in the history