Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and fix non-int-length bug in view(::Memory, ::Union{UnitRange, Base.OneTo}) #53991

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

LilithHafner
Copy link
Member

@LilithHafner LilithHafner commented Apr 8, 2024

We assumed, falsely, that length(inds) isa Int. The length must be convertible to an Int or we throw, but that conversion may need to be explicitly performed.

Fixes #53990

CC @oscardssmith @vtjnash @odow

@LilithHafner LilithHafner added bugfix This change fixes an existing bug backport 1.11 Change should be backported to release-1.11 labels Apr 8, 2024
@LilithHafner LilithHafner added the merge me PR is reviewed. Merge when all tests are passing label Apr 8, 2024
@jishnub jishnub merged commit e4f2124 into master Apr 8, 2024
8 checks passed
@jishnub jishnub deleted the lh/memory-view-fixup branch April 8, 2024 03:46
@KristofferC KristofferC mentioned this pull request Apr 9, 2024
41 tasks
KristofferC pushed a commit that referenced this pull request Apr 9, 2024
… Base.OneTo})` (#53991)

We assumed, falsely, that `length(inds) isa Int`. The length must be
convertible to an `Int` or we throw, but that conversion may need to be
explicitly performed.

Fixes #53990

CC @oscardssmith @vtjnash @odow

(cherry picked from commit e4f2124)
KristofferC added a commit that referenced this pull request Apr 9, 2024
Backported PRs:
- [x] #53757 <!-- Add an IndexStyle example to the diagind docstring -->
- [x] #53809 <!-- Add missing GC_POP() in emit_cfunction -->
- [x] #53789 <!-- also check that UUID of project is non-null when
treating it as a package -->
- [x] #53805 <!-- precompilepkgs: simplify custom config printing if
only one -->
- [x] #53822 <!-- Bump libuv -->
- [x] #53837 <!-- update MPFR to 4.2.1 -->
- [x] #53862 <!-- precompilepkgs: fix error reporting -->
- [x] #53774 <!-- Remove some duplicates from emitted compilation traces
-->
- [ ] #53696 <!-- add invokelatest to on_done callback in bracketed
paste -->
- [x] #53383 <!-- Add `_unsetindex!` methods for `SubArray`s and
`CartesianIndex`es -->
- [x] #53475 <!-- Fix boundscheck in unsetindex for SubArrays -->
- [x] #53888 
- [x] #53870 <!-- Revert change to checksum for llvm-julia -->
- [x] #53906 <!-- Add `Base.isrelocatable(pkg)` -->
- [x] #53833 <!-- Profile: make heap snapshots viewable in vscode viewer
-->
- [x] #53961 <!-- `LazyString` in `LinearAlgebra.checksquare` error
message -->
- [x] #53962 <!-- Use StringMemory instead of StringVector where
possible -->
- [x] #53825 <!-- profile: doc: update the `Allocs.@profile` doc string
-->
- [x] #53975 <!-- `LazyString` in `DimensionMismatch` error messages in
broadcasting -->
- [x] #53905 <!-- Avoid repeated precompilation when loading from
non-relocatable cachefiles -->
- [x] #53896 <!-- Make reshape and view on Memory produce Arrays and
delete wrap -->
- [x] #53991 <!-- Test and fix non-int-length bug in `view(::Memory,
::Union{UnitRange, Base.OneTo})` -->
@tecosaur tecosaur removed the merge me PR is reviewed. Merge when all tests are passing label Apr 10, 2024
@KristofferC KristofferC removed the backport 1.11 Change should be backported to release-1.11 label Apr 17, 2024
KristofferC pushed a commit that referenced this pull request Jun 18, 2024
KristofferC added a commit that referenced this pull request Jun 25, 2024
KristofferC added a commit that referenced this pull request Jun 25, 2024
KristofferC added a commit that referenced this pull request Jul 26, 2024
KristofferC added a commit that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

view(::Memory, ::UnitRange{UInt}) is broken
6 participants