[backport] v1.11: mark Lockable as public and update NEWS.md for Lockable not being exported
#54590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You'll also need to update HISTORY.md on master. |
ericphanson
changed the title
public
fredrikekre
reviewed
May 28, 2024
ericphanson
changed the title
publicpublic and update NEWS.md for Lockable not being exported
Co-authored-by: Fredrik Ekre <[email protected]>
|
I assume this was the wrong way to do this; could you comment on the right way @KristofferC ? |
|
This was the right way but it got auto closed due to the backport branch merging. I'll open a new backport branch and we can merge it into that for the next prerelease. |
|
ah that makes sense, sounds good |
|
Just fyi: there is now a new backports branch for this to target |
|
thanks, I recreated the PR here: #54612 |
lazarusA
pushed a commit
to lazarusA/julia
that referenced
this pull request
Aug 17, 2024
…ing exported in v1.11 (JuliaLang#54595) companion to JuliaLang#54612. As mentioned there, in JuliaLang#54590 we originally intended to export Lockable. This does so for v1.12, and also updates the HISTORY.md for the fact that Lockable was not exported in v1.11 to match JuliaLang#54612.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #52898 we originally intended to export Lockable, but noticed it caused some clashes in the ecosystem. We decided to not export it and merge, with the intent to mark it exported later, which left the NEWS.md out-of-date (as noticed by @jakobnissen).
I think it may be too late for v1.11 to make it exported, so this PR updates the NEWS.md and marks it public.
(see #54595 for a companion to PR to master)