Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "inference: implement an opt-in interface to cache generated sources" #54977

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented Jun 28, 2024

Reverts #54916

@oscardssmith
Copy link
Member

Is the GC issue you mentioned post merge unfixable?

@vtjnash
Copy link
Sponsor Member Author

vtjnash commented Jun 28, 2024

Yes, it is a missing gc_wb that cannot be added to that design

@giordano giordano added the revert This reverts a previously merged PR. label Jun 29, 2024
@aviatesk aviatesk force-pushed the revert-54916-avi/cache-unoptimized-generated branch from 7331859 to 11f5d81 Compare July 1, 2024 05:42
@aviatesk
Copy link
Sponsor Member

aviatesk commented Jul 1, 2024

Yes, it is a missing gc_wb that cannot be added to that design

Would adding some sort of GC annotation to jl_code_for_staged solve the issue, or is a larger refactor likely needed? In the package I'm currently trying to implement, using Core.CachedGenerator is expected to significantly improve performance, so I would like to know how to correctly implement Core.CachedGenerator.

@vtjnash
Copy link
Sponsor Member Author

vtjnash commented Jul 7, 2024

I am not really sure what that parameter does. It seems already very suspicious and sketchy that a function that is defined to be a pure transform of input arguments to CodeInfo is returning something that is mutable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
revert This reverts a previously merged PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants