use iszero in isinteger(::AbstractFloat) #55276
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very slight tweak to the implementation of
isinteger(::AbstractFloat)
to useiszero
rather than== 0
. It shouldn't make any difference with any of the built-in floating-point types, butiszero
might conceivably be faster for some user-defined types.I also added a comment to indicate why it's using
iszero(x - trunc(x))
rather thanx == trunc(x)
(due to non-finite values); this code dates back to #14569 in Julia 0.5.