Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix overlapping definitions of Base.active_module and REPL.active_module #55316

Merged
merged 1 commit into from
Aug 16, 2024
Merged

fix overlapping definitions of Base.active_module and REPL.active_module #55316

merged 1 commit into from
Aug 16, 2024

Conversation

JeffBezanson
Copy link
Sponsor Member

I'm hoping this will fix #54888 but I haven't been able to reproduce it so maybe somebody else can confirm.

@JeffBezanson JeffBezanson added the REPL Julia's REPL (Read Eval Print Loop) label Jul 30, 2024
vtjnash
vtjnash reviewed Jul 30, 2024
View reviewed changes
base/show.jl Show resolved Hide resolved
@JeffBezanson
Copy link
Sponsor Member Author

This is hopefully ok now.

  • Removed the strange function is_exported_from_stdlib that did not really do what it sounds like. These cases should just use isvisible IMO.
  • Switch back to defaulting to Main instead of active_module. It's not ideal but needed for compatibility.

@JeffBezanson
Copy link
Sponsor Member Author

@nanosoldier runtests(ALL, vs = ":master")

@nanosoldier
Copy link
Collaborator

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

@JeffBezanson
don't call active_module() for printing type, function, and enum names
9a564d4 
fix overlapping definitions of `Base.active_module` and `REPL.active_module`
@JeffBezanson
Copy link
Sponsor Member Author

JeffBezanson commented Aug 15, 2024 •
edited
Loading

OK there was one package test failure that was actually expecting a qualified name, which is preferred since it is less state-dependent, so I switched function printing back to something more compatible with is_exported_from_stdlib. This is a good thing since it's more stable than using Main or active_module.

@JeffBezanson JeffBezanson merged commit ddecfe7 into master Aug 16, 2024
7 checks passed
@JeffBezanson JeffBezanson deleted the jb/activemodule branch August 16, 2024 18:14
@JeffBezanson JeffBezanson mentioned this pull request Aug 16, 2024
Closed
lazarusA pushed a commit to lazarusA/julia that referenced this pull request Aug 17, 2024
@JeffBezanson @lazarusA
fix overlapping definitions of Base.active_module and `REPL.active_…
d38a442 
…module` (JuliaLang#55316)

also avoid calling `active_module` from low-level printing functions
fix JuliaLang#54888
KristofferC pushed a commit that referenced this pull request Sep 12, 2024
@JeffBezanson
fix overlapping definitions of Base.active_module and `REPL.active_…
0d6ef4d 
…module` (#55316)

also avoid calling `active_module` from low-level printing functions
fix #54888
@vtjnash vtjnash mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

@KristofferC KristofferC KristofferC left review comments

Assignees
No one assigned
Labels
REPL Julia's REPL (Read Eval Print Loop)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Base.active_module() design is very badly broken on master
4 participants
@JeffBezanson @nanosoldier @vtjnash @KristofferC