Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integers in the type domain #55571

Closed
wants to merge 64 commits into from
Closed

Integers in the type domain #55571

wants to merge 64 commits into from

Commits on Aug 23, 2024

  1. import from src/ from my package TypeDomainNaturalNumbers.jl 

    https://gitlab.com/nsajko/TypeDomainNaturalNumbers.jl
    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    a36791a View commit details
    Browse the repository at this point in the history

  2. rename module TypeDomainNaturalNumbers to TypeDomainIntegers

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    da72b8b View commit details
    Browse the repository at this point in the history

  3. add copyright notice

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    22991b8 View commit details
    Browse the repository at this point in the history

  4. include the new file into Base

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    48ed9e5 View commit details
    Browse the repository at this point in the history

  5. make the new types subtype Integer

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    e71bf9b View commit details
    Browse the repository at this point in the history

  6. delete NegativeInteger constructor to prevent ambiguity

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    2bf4b17 View commit details
    Browse the repository at this point in the history

  7. delete with_refined_type, just use the type assertion directly

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3b93756 View commit details
    Browse the repository at this point in the history

  8. don't add ambiguous methods to Base

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    ee728a5 View commit details
    Browse the repository at this point in the history

  9. refactor: introduce interoperable

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    97c0d82 View commit details
    Browse the repository at this point in the history

  10. base the interoperability with other numbers on Int8 

    Use `Int8` instead of `Int`, according to the principle of least power.
Protect againt unnecessary promotion.
    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3f5a1a7 View commit details
    Browse the repository at this point in the history

  11. support conversion from/to other primitive types

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    59af5d8 View commit details
    Browse the repository at this point in the history

  12. interoperable: return Bool when possible

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    81b9621 View commit details
    Browse the repository at this point in the history

  13. import the tests from my Gitlab, adjust

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    e7b09c5 View commit details
    Browse the repository at this point in the history

  14. fix dispatch to conversion to Bool

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    e4ba24f View commit details
    Browse the repository at this point in the history

  15. export the apply_ functions from BaseHelpers

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    a05a7ec View commit details
    Browse the repository at this point in the history

  16. delete apply_ fallbacks

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    302fa38 View commit details
    Browse the repository at this point in the history

  17. implement apply_ for equality

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    33db6a5 View commit details
    Browse the repository at this point in the history

  18. implement promotion

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    d216418 View commit details
    Browse the repository at this point in the history

  19. instead of forcing a narrow type, widen on overflow

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    728e59e View commit details
    Browse the repository at this point in the history

  20. BaseHelpers: simplify, tdi_to_int now may return Bool

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    15698f4 View commit details
    Browse the repository at this point in the history

  21. BaseHelpers: interoperable -> tdi_to_int

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    d3f8933 View commit details
    Browse the repository at this point in the history

  22. BaseHelpers: bugfix for equality: import iszero

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    a0b0c9a View commit details
    Browse the repository at this point in the history

  23. BaseHelpers: a - b -> a + -b 

    Addition is the more basic operation, avoid subtracting unnecessarily.
    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    3c29e5b View commit details
    Browse the repository at this point in the history

  24. define binary operations using BaseHelpers

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    ade3b06 View commit details
    Browse the repository at this point in the history

  25. implement abs

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    6f463f4 View commit details
    Browse the repository at this point in the history

  26. implement promotion between TypeDomainInteger subtypes

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    8a3b13f View commit details
    Browse the repository at this point in the history

  27. implement conversion to AbstractFloat

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    f213c52 View commit details
    Browse the repository at this point in the history

  28. delete tdnn_to_x, it's unused

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    9fcf4a2 View commit details
    Browse the repository at this point in the history

  29. implement tdnn_from_int(::Bool), tdi_from_int(::Bool)

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    6858b76 View commit details
    Browse the repository at this point in the history

  30. implement <:AbstractFloat constructors taking RoundingMode

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    49809ff View commit details
    Browse the repository at this point in the history

  31. implement signbit

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    8799b83 View commit details
    Browse the repository at this point in the history

  32. implement sign

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    7dd4350 View commit details
    Browse the repository at this point in the history

  33. specialize inv

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    47b6abc View commit details
    Browse the repository at this point in the history

  34. implement widen

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    9835209 View commit details
    Browse the repository at this point in the history

  35. specialize show

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    de6b57b View commit details
    Browse the repository at this point in the history

  36. use TypeDomainIntegers from Base

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    58dd019 View commit details
    Browse the repository at this point in the history

  37. implement isqrt

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    730a5aa View commit details
    Browse the repository at this point in the history

  38. implement factorial

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    af5bc27 View commit details
    Browse the repository at this point in the history

  39. to_power_type(@nospecialize x::TypeDomainInteger) = x

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    29a3435 View commit details
    Browse the repository at this point in the history

  40. use TypeDomainIntegers from Base.Math

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    0a99dc0 View commit details
    Browse the repository at this point in the history

  41. math: implement sqrt cbrt, fourthroot

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    6545620 View commit details
    Browse the repository at this point in the history

  42. math: hypot(x::TypeDomainInteger) = abs(x)

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    8c1920a View commit details
    Browse the repository at this point in the history

  43. math: specialize deg2rad, rad2deg

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    de04594 View commit details
    Browse the repository at this point in the history

  44. math: specialize logarithms

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    b2e9757 View commit details
    Browse the repository at this point in the history

  45. math: specialize exp2, exp10, expm1

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    5670b8d View commit details
    Browse the repository at this point in the history

  46. math: specialize some hyperbolic functions

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    c4f0c51 View commit details
    Browse the repository at this point in the history

  47. math: specialize sind, asind, cosd, acosd, secd, asecd

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    1bceeb6 View commit details
    Browse the repository at this point in the history

  48. math: specialize sinpi, cospi, tanpi 

    For `sinpi` and `tanpi`, this loses the distinction between the signed
zeros of the previous implementation. That said, as far as I
understand, the distinction was nonsensical, because for both the sine
and the tangens each zero is a zero-crossing (the graph intersects the
x-axis, as opposed to just touching the x-axis).

So, as far as I understand, this change should be fine.
    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    59bff74 View commit details
    Browse the repository at this point in the history

  49. math: specialize sinc, cosc

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    95d9cea View commit details
    Browse the repository at this point in the history

  50. complex: specialize imag(::Real)

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    301b575 View commit details
    Browse the repository at this point in the history

  51. complex: specialize cispi

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    21dd6b9 View commit details
    Browse the repository at this point in the history

  52. rational: make denominator(::Integer) return type domain one

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    8d02b19 View commit details
    Browse the repository at this point in the history

  53. gmp: conversion from BigInt

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    b8abb9e View commit details
    Browse the repository at this point in the history

  54. mpfr: conversion from BigFloat

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    4ab3521 View commit details
    Browse the repository at this point in the history

  55. irrationals: zero, one, sign

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    51c2863 View commit details
    Browse the repository at this point in the history

  56. MathConstants: return type domain integers when that makes sense

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    fb97552 View commit details
    Browse the repository at this point in the history

  57. specialize: angle exp sin tan cos asin atan acos

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    1a62a82 View commit details
    Browse the repository at this point in the history

  58. gmp, mpfr, irrationals: define binary operations using BaseHelpers

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    c6b1a50 View commit details
    Browse the repository at this point in the history

  59. update tests: relax === to ==

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    8f16391 View commit details
    Browse the repository at this point in the history

  60. test issue JuliaLang#37977

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    7de1320 View commit details
    Browse the repository at this point in the history

  61. complex: nospecialize for cispi

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    8900ea3 View commit details
    Browse the repository at this point in the history

  62. InteractiveUtils: fix/disable doc test

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    2116f13 View commit details
    Browse the repository at this point in the history

  63. uncomment some tests

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    eaa25f9 View commit details
    Browse the repository at this point in the history

  64. delete redundant isequal and == methods

    @nsajko
    nsajko committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    55c423b View commit details
    Browse the repository at this point in the history