IRShow: label builtin / intrinsic / dynamic calls in code_typed
#56036
+178
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
added
the
display and printing
aviatesk
reviewed
Oct 8, 2024
topolarity
force-pushed
the
ct/print-builtin-intrinsic
branch
8 times, most recently
from
664e5fb
to
6b8ba52
Compare
topolarity
force-pushed
the
ct/print-builtin-intrinsic
branch
from
6b8ba52
to
739ac62
Compare
|
This needs a change to LoweredCodeUtils.jl before it won't break Revise |
vtjnash
reviewed
Oct 10, 2024
topolarity
added a commit
to topolarity/LoweredCodeUtils.jl
that referenced
this pull request
Oct 10, 2024
topolarity
force-pushed
the
ct/print-builtin-intrinsic
branch
from
e9dd88e
to
4ebb14f
Compare
aviatesk
pushed a commit
to JuliaDebug/LoweredCodeUtils.jl
that referenced
this pull request
Oct 11, 2024
This makes it much easier to spot dynamic dispatches:
```julia
3 ── %9 = (isa)(%4, @NamedTuple{x::Int64, y})::Bool
└─── goto JuliaLang#5 if not %9
4 ── %11 = π (%4, @NamedTuple{x::Int64, y})
└─── goto JuliaLang#6
5 ── %13 = (Tuple{Int64, Any})(%4)::Tuple{Int64, Any}
│ %14 = (getfield)(%13, 1)::Int64
│ %15 = (getfield)(%13, 2)::Any
│ %16 = %new(@NamedTuple{x::Int64, y}, %14, %15)::@NamedTuple{x::Int64, y}
```
is now:
```julia
3 ── %9 = builtin (isa)(%4, @NamedTuple{x::Int64, y})::Bool
└─── goto JuliaLang#5 if not %9
4 ── %11 = π (%4, @NamedTuple{x::Int64, y})
└─── goto JuliaLang#6
5 ── %13 = dynamic (Tuple{Int64, Any})(%4)::Tuple{Int64, Any}
│ %14 = builtin (getfield)(%13, 1)::Int64
│ %15 = builtin (getfield)(%13, 2)::Any
│ %16 = %new(@NamedTuple{x::Int64, y}, %14, %15)::@NamedTuple{x::Int64, y}
```
This is on by default when displaying a CodeInfo, and off by default
for `code_warntype`, unless optimize=true. Can be enabled / disabled
via IRShowConfig.label_dynamic_calls
topolarity
force-pushed
the
ct/print-builtin-intrinsic
branch
from
eee1a01
to
594079b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it much easier to spot dynamic dispatches:
is now:
