Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparse-Uint: bug fix & added performance tests #7201

Merged
merged 1 commit into from
Jun 10, 2014

Conversation

mauro3
Copy link
Contributor

@mauro3 mauro3 commented Jun 10, 2014

This PR does:

  • fix a bug in getindex_general. Indexing with a disordered array lead to a no-methods error:
    ERROR: no method SparseMatrixCSC{Tv,Ti<:Integer}(Int64, Int64, Array{Int64,1}, Array{Uint32,1}, Array{Float64,1}) Test added.
  • temprary fix for optimizer bug on ind2sub #7197 in test/sparse.jl
  • added performance tests for Sparse-uint matrices

This PR does:
- fix a bug in getindex_general.  Indexing with a disordered
  array lead to a no-methods error. Test added
- temprary fix for JuliaLang#7197 in `test/sparse.jl`
- added performance tests for Sparse-uint matrices
@ViralBShah
Copy link
Member

Test failure seems unrelated.

ViralBShah added a commit that referenced this pull request Jun 10, 2014
Sparse-Uint: bug fix & added performance tests
@ViralBShah ViralBShah merged commit 1f0c89a into JuliaLang:master Jun 10, 2014
@mauro3 mauro3 deleted the sparse_perf_bug1 branch June 10, 2014 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants