[WIP] Update gmp to 6.0.0 #7957
Conversation
|
Don't merge this yet, need to check distribution package compatibility |
| @@ -1443,6 +1443,9 @@ gmp-$(GMP_VER).tar.bz2: | |||
| gmp-$(GMP_VER)/configure: gmp-$(GMP_VER).tar.bz2 | |||
| $(JLCHECKSUM) $< | |||
| $(TAR) jxf $< | |||
| ifeq ($(OS), Darwin) | |||
| cd gmp-$(GMP_VER) && patch -p1 < ../gmp_6.0.0_osx.patch | |||
| endif | |||
There was a problem hiding this comment.
Should you also check that we actually use 6.0.0, not 6.0.1 before patching?
There was a problem hiding this comment.
I don't think we'll ever support building different GMP versions like we do with LLVM. So we'll just take this line out when we upgrade next.
There was a problem hiding this comment.
Yea, it is probably more important to ensure that it is removed when obsoleted.
There was a problem hiding this comment.
If the patch doesn't apply anymore, it will fail, and the user will get an error, so it'll be noticed relatively quickly, I'd hope.
|
Bump. Can we merge this? |
|
Everything that the test suite exercises that's in both 5.1.3 and 6.0.0 seemed to work fine everywhere I ran it. We only need to worry about waiting for distributions to package 6.0.0 if we want to start using new API's that don't exist in the old version, right @staticfloat? |
|
That's right, but at least some of the distributions that I've checked do indeed have gmp 6, so I think we're good to go on this front. |
|
For now, we can just use 6.0 without the new APIs. By the time 0.4 is released, distros will have caught up for sure. |
|
Oddly looks like the file got renamed to 6.0.0a... and would anyone mind if I switched this to use https instead of ftp? This is the only thing in |
|
Please do use |
|
Heh. The Windows VM I've been playing with provisioning was having trouble with the GMP download, possibly because of ftp and/or the file having been renamed. |
Closes #7858