Fix #8257 #8273
Merged
Fix #8257 #8273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this within the scope of @JuliaBackports? |
|
Yes I think we could backport this. Could you add a test as well? |
|
Random and floating point inaccuracies is really hard to test. I made a simple attempt. I also changed |
|
Sorry, the first commit was without the test. |
| @@ -219,17 +219,9 @@ end | |||
| rand!{T<:Union(Signed,Unsigned,Bool,Char)}(r::UnitRange{T}, A::AbstractArray) = rand!(RandIntGen(r), A) | |||
|
|
|||
| function rand!{T}(r::Range{T}, A::AbstractArray) | |||
There was a problem hiding this comment.
With this change you can get rid of parametrisation by T, no?
This version of `rand(r::Range)` and `rand!(r::Range,a::AbstractArray)` uses getindex instead of trying to calculate the exact value of the range. This is good because we avoid duplicating the getindex logic in `FloatRange` Also added tests, and fixed a small issue in `in(v, r::Range)` where two calls to step() is not needed
|
I decided to merge this so that @rfourquet can easier base his work on this change. If nobody has objections in a few days, I will also backport to |
|
+1 for backporting |
ivarne
added a commit
that referenced
this pull request
Sep 15, 2014
This version of `rand(r::Range)` and `rand!(r::Range,a::AbstractArray)` uses getindex instead of trying to calculate the exact value of the range. This is good because we avoid duplicating the getindex logic in `FloatRange` Also added tests, and fixed a small issue in `in(v, r::Range)` where two calls to step() is not needed Backport of 48f27bc PR: #8273
|
Backported in 7edddb0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new version of
rand(r::Range)andrand!(r::Range,a::AbstractArray)uses getindex instead of trying to calculate the exact value of the
range. This is good because we avoid duplicating the getindex logic in
FloatRange