Consistently parse A <: B as a Expr(:comparison, A, :(<:), B) #9582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix #9503 This is a backwards incompatible change, note that before ```julia type A <: B end ``` would be parsed as: ```julia Expr(:type, true, Expr(:(<:), :A, :B), Expr(:block,)) ``` now it is parsed as ```julia Expr(:type, true, Expr(:comparison, :A, :(<:), :B), Expr(:block,)) ``` chained subtype comparisons for type/immutable are still disallowed ```julia type A <: B <: C end ```
| @@ -972,9 +974,9 @@ | |||
| (values name '() 'Any)) ex) | |||
| ((pattern-lambda (curly (-- name (-s)) . params) | |||
| (values name params 'Any)) ex) | |||
| ((pattern-lambda (|<:| (-- name (-s)) super) | |||
| ((pattern-lambda (comparison (-- name (-s)) <: super) | |||
There was a problem hiding this comment.
Needs to be (-/ <:) to make it match a literal <:. Otherwise <: is a pattern variable like other symbols.
There was a problem hiding this comment.
Ok, failure to match this pattern is the reason this worked at all. Thanks.
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #9503
This is a backwards incompatible change, note that before
would be parsed as:
now it is parsed as
chained subtype comparisons for type/immutable are still disallowed