Eliminate recommendation to use atsign-assert #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once the build has completed, you can preview your PR at this URL: https://julialang.netlify.app/previews/PR1363/ in ~15 minutes |
KristofferC
reviewed
Aug 25, 2021
| @@ -625,8 +625,7 @@ false | |||
| ``` | |||
|
|
|||
| Even though `double` can't be compiled for `String`, the corresponding `precompile` doesn't error, it only returns `false`. | |||
| If you want to monitor the utility of your `precompile` directives, sometimes it's useful to preface them with `@assert`; all's well if precompilation succeeds, but if changes to the package mean that the precompile directive has "gone bad," then you get an error. | |||
| Hopefully, such errors would be caught before shipping the package to users! | |||
| Julia 1.7 will warn about inactive precompile directives. | |||
|
@timholy Is this ok to merge? |
|
It seems settled now, so yes. I updated the branch, when the tests finish this can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ugh, didn't realize this was still hanging around.