Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MulAdd's CZeros to remove duplicate zero-fill #424

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Feb 2, 2024

With this, multiplying a BandedMatrix by a OneElementVector would be as performant as slicing.

julia> B = brand(6000,6000,4000,4000); O = OneElement(1, 3, size(B,2));

julia> @btime $B * $O;
  3.826 μs (2 allocations: 46.92 KiB)

julia> @btime $B[:,$O.ind...];
  4.013 μs (4 allocations: 47.00 KiB)

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (ff75189) 89.55% compared to head (213a970) 89.59%.
Report is 2 commits behind head on master.

Files Patch % Lines
src/banded/gbmm.jl 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
+ Coverage   89.55%   89.59%   +0.03%     
==========================================
  Files          25       25              
  Lines        3544     3557      +13     
==========================================
+ Hits         3174     3187      +13     
  Misses        370      370              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jishnub jishnub merged commit 13b11fc into JuliaLinearAlgebra:master Feb 2, 2024
13 checks passed
@jishnub jishnub deleted the CZerosMulAdd branch February 2, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant