Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #1

Closed
4 tasks done
tkf opened this issue Oct 17, 2019 · 9 comments
Closed
4 tasks done

Release #1

tkf opened this issue Oct 17, 2019 · 9 comments

Comments

@tkf
Copy link
Collaborator

tkf commented Oct 17, 2019

Continuing discussion from: JunoLab/Juno.jl#400

@pfitzseb Is there something you want to do before registering it?

@pfitzseb
Copy link
Member

Is name OK? I just realized that the name crashes with @adamslc's ProgressLogging.jl although it's not registered.

IMHO the name is fine (ProgressBase.jl could work too, but seems less descriptive).

Is API OK? I have some suggestions but since this API is already out in the wild, I think releasing it as-is first makes sense.

Agreed. Let's get this out in the current form and iterate over the API afterwards (ideally with deprecation warnings).

Would be good to have a minimal readme before registering, but apart from that this should be good to go.

@tkf
Copy link
Collaborator Author

tkf commented Oct 17, 2019

ProgressBase.jl could work too, but seems less descriptive

I thought about this too, but ProgressBase.jl sounds like a low-level package for package authors. This package is likely to be used by end-users (e.g., in some scripts). So I wanted something else.

Would be good to have a minimal readme before registering

Good point. Will do.

This reminds me that it's also better to set up Documenter. Can you do this? I don't have access to the ⛭ Settings tab.

@pfitzseb
Copy link
Member

I thought about this too, but ProgressBase.jl sounds like a low-level package for package authors.

I'd like to think of this package as something package authors use. I know @ChrisRackauckas has been using Juno.@progress for a while. But yeah, let's just keep the current name.

This reminds me that it's also better to set up Documenter. Can you do this? I don't have access to the ⛭ Settings tab.

Sure, will do.

@pfitzseb
Copy link
Member

Alright, anything else we want to change before the first release?

@tkf
Copy link
Collaborator Author

tkf commented Oct 24, 2019

The last concern for me is what to do with @logprogress API #7 (comment)

@tkf
Copy link
Collaborator Author

tkf commented Oct 25, 2019

How about releasing after #11?

@tkf
Copy link
Collaborator Author

tkf commented Nov 5, 2019

@JuliaRegistrator register

@pfitzseb Thanks for reviewing #11!

@pfitzseb
Copy link
Member

pfitzseb commented Nov 6, 2019

Turns out JuliaRegistrator wasn't installed on the repo, so

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Registration pull request created: JuliaRegistries/General/5110

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if Julia TagBot is installed, or can be done manually through the github interface, or via:

git tag -a v0.1.0 -m "<description of version>" 0eae8c65950be40ceb7e20900c58bc66f3bd3024
git push origin v0.1.0

@tkf tkf closed this as completed Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants