Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Decouple progress frontend #400

Closed
tkf opened this issue Oct 16, 2019 · 6 comments
Closed

[FR] Decouple progress frontend #400

tkf opened this issue Oct 16, 2019 · 6 comments

Comments

@tkf
Copy link
Member

tkf commented Oct 16, 2019

IIUC, due to Juno-specific check in @progress macro implementation, code using @progress can only work inside Juno:

Juno.jl/src/progress.jl

Lines 105 to 106 in 554707e

if isactive()
@logmsg($PROGRESSLEVEL, $(esc(name)), progress=0.0, _id=Symbol($_id))

The specification in Juno.progress docstring also does not specify that using LogLevel(-1) is crucial.

These are issues I noticed while writing a ProgressMeter-Logging bridge ProgressMeterLogging.jl and adding a frontend support in my package JuliaFolds/Transducers.jl#63. I think a cleaner solution may be having a base package with a spec and a reference implementation of frontend progress macros and functions.

What do you think? Is it a good approach to decouple progress logging interface (frontend API and specification documentation) from Juno?

@pfitzseb
Copy link
Member

Yes, definitely.

does not specify that using LogLevel(-1) is crucial.

It isn't for Juno's implementation -- any logging level higher or equal to -1 works (or higher than the min_enabled_level of the global logger). Should still be documented though.

@tkf
Copy link
Member Author

tkf commented Oct 17, 2019

OK, I created https://github.com/tkf/ProgressLogging.jl. Do you want to move it to https://github.com/JunoLab?

@pfitzseb
Copy link
Member

Sure, why not -- invited you to the org. Thanks for splitting out the code!

@tkf
Copy link
Member Author

tkf commented Oct 17, 2019

I got a permission error when I tried to transfer it to JunoLab so I transferred the repository to you. Can you move it to JunoLab?

@pfitzseb
Copy link
Member

Hm, weird. Should be transferred now.

@tkf
Copy link
Member Author

tkf commented Oct 17, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants