Add Formatter (spec + CI step) #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we bump this one? |
|
Seems like the failures here are due to not having an API key for the testing suite. I'd recommend we merge this in since the changes are cosmetic and the JuliaFormatter step seems appropriate. |
|
Happy to merge this as soon as the conflicts are resolved. I can resolve in the morning, almost kicked this illness |
|
Hey! Sorry to hear you were sick... Let me refresh it with Main -- it's a simple formatter, so it shouldn't take any effort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #55
This PR introduces 3 changes:
.JuliaFormatter.tomlformatting spec set to SciML formatting guidelinesWhy? It saves you time. You don't have to add spaces manually, you don't have to disabled your VSCode auto-formatter, etc. It all just works.
The code does not look pretty and sometimes it looks a bit suboptimal (too many lines), but it never impacts readability negatively.
Let me know what you think!
EDIT: the large amount of change is purely the effect of running the formatter. I haven't touched any files besides the ones outlined above.