Only compute Jacobian in RLM if last step success #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
==========================================
+ Coverage 99.74% 99.76% +0.01%
==========================================
Files 77 77
Lines 7087 7089 +2
==========================================
+ Hits 7069 7072 +3
+ Misses 18 17 -1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mateuszbaran
approved these changes
Oct 12, 2023
kellertuer
approved these changes
Oct 17, 2023
|
No, tagging is not urgent as I can work on the master branch locally and CI will still pass as it's only a performance enhancement. |
|
Ok, nice, I'll merge it to master and it will be part of the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The estimate
lms.pis only updated on a successful step, therefore a Jacobian is not needed if the last step failed.This PR skips updating the Jacobian if the last step failed.