fix T(x::T) ambiguity (closes #85)

JuliaMath · Jan 11, 2019 · fb4928d · fb4928d
1 parent ad5f8ad
commit fb4928d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/DecFP.jl b/src/DecFP.jl
@@ -102,9 +102,10 @@ for w in (32,64,128)
     Ti = Symbol(string("UInt",w))
     @eval struct $BID <: DecimalFloatingPoint
         x::$Ti
-        $BID(x) = convert($BID, x)
+        $BID(x::Number) = convert($BID, x)
         Base.reinterpret(::Type{$BID}, x::$Ti) = new(x)
     end
+    # fix method ambiguities:
     @eval $BID(x::Rational{T}) where {T} = convert($BID, x)
 end
 

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -208,6 +208,9 @@ for T in (Dec32, Dec64, Dec128)
 
     @test typeof(xd * pi) == T
     @test typeof((xd+yd*im)*pi) == Complex{T}
+
+    # issue #85
+    @test T(1.5) == T(T(1.5))
 end
 
 @test unsafe_load(DecFP.flags[]) == 0