Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faster exp* #136

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

faster exp* #136

wants to merge 5 commits into from

Conversation

oscardssmith
Copy link
Member

Part 1 of 2 solution to #135. This still needs some testing, but I think it is pretty good as is. I benchmark it to be 10x faster and more accurate (on a small sample of points).

@oscardssmith
Copy link
Member Author

This unfortunately isn't quite as accurate as exp. I was comparing accuracy of this exp2 vs main, but on main exp is significantly more accurate than exp2. As such, this PR currently is a minor accuracy regression, which I need to fix.

@JeffreySarnoff
Copy link
Member

Is this only failing for versions < 1.6 ?

@oscardssmith
Copy link
Member Author

I don't think so. I believe the accuracy isn't ideal on any version yet.

@JeffreySarnoff
Copy link
Member

I don't think so. I believe the accuracy isn't ideal on any version yet.

Do you recall any pattern to the inaccuracy?

@oscardssmith
Copy link
Member Author

I'm just not compensating enough of the error. (so the error is a little high pretty much across the board)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants