Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using ANY #22

Merged
merged 1 commit into from
Jul 17, 2017
Merged

Stop using ANY #22

merged 1 commit into from
Jul 17, 2017

Conversation

andreasnoack
Copy link
Member

It is not a thing anymore

@ararslan
Copy link
Member

It's not equivalent to Any though; I thought it required the new @nospecialize macro?

@andreasnoack
Copy link
Member Author

I'm not sure but I thought this only made a difference for the arguments of the function and not when used as a type parameter like this. We should probably consult the authorities.

@giordano
Copy link
Member

giordano commented Jul 17, 2017

Unrelated, the CI logs on nightly are showing dozens hundreds of messages like those reported at JuliaLang/julia#22763 (comment) for SpecialFunctions.jl, see e.g. https://travis-ci.org/JuliaMath/FFTW.jl/jobs/254462935#L785

@ararslan
Copy link
Member

@giordano Yeah, FFTW is just a hot mess in general right now.

@giordano
Copy link
Member

I opened a ticket (#23) as a reminder.

@ararslan ararslan merged commit 48923f4 into master Jul 17, 2017
@ararslan ararslan deleted the anj/any branch July 17, 2017 17:55
@JeffBezanson
Copy link
Contributor

You might need (::Type{r2rFFTWPlan{$Tr,A,inplace,N}} where A) for this to match the same methods as before.

@ararslan ararslan mentioned this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants