Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new AbstractFFTs.AdjointStyle trait for FFT and DCT plans #249

Merged
merged 8 commits into from
Sep 4, 2023

Conversation

gaurav-arya
Copy link
Contributor

@gaurav-arya gaurav-arya commented Aug 17, 2022

Supports the new AbstractFFTs.AdjointStyle trait. This is a draft PR because JuliaMath/AbstractFFTs.jl#78 and JuliaMath/AbstractFFTs.jl#109 are not merged yet, which this PR relies on.

@vpuri3
Copy link

vpuri3 commented Jul 7, 2023

@gaurav-arya where is testbackend.jl?

@devmotion devmotion mentioned this pull request Jul 8, 2023
@gaurav-arya
Copy link
Contributor Author

I think you can remove that: it was one attempt at reusing AbstractFFTs' tests here but we haven't yet agreed on a good solution, see JuliaMath/AbstractFFTs.jl#78.

If you'd like to push this through perhaps if you can think of a minimal self contained test here to test the traits, we could sidestep the problem and get this merged (note I don't have merge rights, so ultimately the decision should be verified with someone who does).

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +2.08% 🎉

Comparison is base (008bc5b) 70.99% compared to head (969315a) 73.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   70.99%   73.08%   +2.08%     
==========================================
  Files           5        5              
  Lines         531      535       +4     
==========================================
+ Hits          377      391      +14     
+ Misses        154      144      -10     
Files Changed Coverage Δ
src/dct.jl 91.66% <100.00%> (+10.81%) ⬆️
src/fft.jl 70.56% <100.00%> (+1.38%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gaurav-arya gaurav-arya marked this pull request as ready for review July 30, 2023 01:21
@gaurav-arya
Copy link
Contributor Author

This is ready!

src/dct.jl Show resolved Hide resolved
@gaurav-arya gaurav-arya changed the title Support new AbstractFFTs.AdjointStyle trait Support new AbstractFFTs.AdjointStyle trait for FFT and DCT plans Jul 30, 2023
@gaurav-arya
Copy link
Contributor Author

Bump

@stevengj
Copy link
Member

stevengj commented Sep 4, 2023

LGTM.

@stevengj stevengj merged commit ef8fc5b into JuliaMath:master Sep 4, 2023
32 checks passed
@vpuri3 vpuri3 deleted the projection branch September 5, 2023 18:19
@gaurav-arya
Copy link
Contributor Author

gaurav-arya commented Sep 12, 2023

@stevengj could FFTW get a release for this PR? It would be helpful for including FFTW's run of the test suite in downstream tests for JuliaMath/AbstractFFTs.jl#118

@stevengj stevengj mentioned this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants