Adds tests for Type Stability of FD functions. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test that most of the API functions for FixedDecimals are type stable in their return type, using the `@inferred` test macro. Tests this for all built-in integer types, across many precisions. (Adds around 10 seconds to test time.)
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
+ Coverage 96.49% 96.51% +0.02%
==========================================
Files 1 1
Lines 171 172 +1
==========================================
+ Hits 165 166 +1
Misses 6 6
Continue to review full report at Codecov.
|
omus
reviewed
Feb 13, 2019
Make all the inferred tests actually test the return type is the correct
type by comparing `===` instead of `==`.
Make the unary test `@inferred(typemax(FD{T,f}))` test that the return
type is the correct type via `isa`.
|
Should be good now then. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that most of the API functions for FixedDecimals are type stable in
their return type, using the
@inferredtest macro.Tests this for all built-in integer types, across many precisions.
(Adds around 10 seconds to test time.)
My changes in PR #45 introduced a type instability I didn't know about. I fixed it and added unit tests for type stability of multiplication in these two commits, #45/files/beb1d3..11ee5e14, but I think that a nicer solution might just be to add type-stability tests across the whole API, so that these kinds of mistakes would be caught in the future. :)
This is a test-only change so hopefully is easy to review. :)
Cheers!