Add support for three-arg div to FixedDecimals in Julia 1.4+
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit simply implements `div(x,y,::RoundingMode)` for FixedDecimals by delegating to `div` of the fields.
TotalVerb
reviewed
Feb 1, 2020
TotalVerb
reviewed
Feb 1, 2020
Before:
```julia
julia> let FD2 = FixedDecimal{Int,2}
cld(FD2(0.01), FD2(2))
end
FixedDecimal{Int64,2}(0.00)
```
After:
```julia
julia> let FD2 = FixedDecimal{Int,2}
cld(FD2(0.01), FD2(2))
end
FixedDecimal{Int64,2}(1.00)
```
NHDaly
commented
Feb 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 92.13% 97.76% +5.63%
==========================================
Files 1 1
Lines 178 179 +1
==========================================
+ Hits 164 175 +11
+ Misses 14 4 -10
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for three-arg div by implementing
div(x,y,::RoundingMode)for FixedDecimals that delegates todivof the fields.Remaining question: Is this enough? Do we also need to implement the three-arg
fld,mod, etc?Fixes #50.