Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamma measure #153

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Gamma measure #153

wants to merge 2 commits into from

Conversation

gdalle
Copy link
Collaborator

@gdalle gdalle commented Aug 26, 2021

Hey @cscherrer
Here's the implementation of the Gamma measure based on the version from Distributions.jl, with both standard parametrizations from Wikipedia.

@github-actions
Copy link
Contributor

Package name latest stable
Mitosis.jl
Soss.jl

@cscherrer
Copy link
Collaborator

cscherrer commented Aug 26, 2021

Thanks @gdalle . This is looking good, I think we just need a few more functions and some tests.

Weirdly, tests here are failing, for code that passed before, passes locally for me, and is completely outside your changes. I don't think there's anything for you to do about that, but I'll need to figure out what's going on.

EDIT: I figured it out! A test was incorrectly passing before I fixed some things in the last MeasureBase. I'll change it so it passes again.

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

Merging #153 (0afa05c) into master (3928dfb) will decrease coverage by 0.53%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   33.81%   33.27%   -0.54%     
==========================================
  Files          29       30       +1     
  Lines         556      565       +9     
==========================================
  Hits          188      188              
- Misses        368      377       +9     
Impacted Files Coverage Δ
src/MeasureTheory.jl 50.00% <ø> (ø)
src/parameterized/gamma.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3928dfb...0afa05c. Read the comment docs.

@github-actions
Copy link
Contributor

Package name latest stable
Mitosis.jl
Soss.jl

@gdalle
Copy link
Collaborator Author

gdalle commented Aug 27, 2021

What kind of additional functions did you have in mind?

@cscherrer
Copy link
Collaborator

Sorry that was vague, the failing tests had me pretty distracted. Offhand I didn't see a method for testvalue. We'll also need some tests. Could you add some similar to other parameterized measures? These are in test/runtests.jl. In general we really need to improve our test coverage.

Thanks again for your work on this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants