-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gamma measure #153
base: master
Are you sure you want to change the base?
Gamma measure #153
Conversation
Thanks @gdalle . This is looking good, I think we just need a few more functions and some tests. Weirdly, tests here are failing, for code that passed before, passes locally for me, and is completely outside your changes. I don't think there's anything for you to do about that, but I'll need to figure out what's going on. EDIT: I figured it out! A test was incorrectly passing before I fixed some things in the last MeasureBase. I'll change it so it passes again. |
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
- Coverage 33.81% 33.27% -0.54%
==========================================
Files 29 30 +1
Lines 556 565 +9
==========================================
Hits 188 188
- Misses 368 377 +9
Continue to review full report at Codecov.
|
What kind of additional functions did you have in mind? |
Sorry that was vague, the failing tests had me pretty distracted. Offhand I didn't see a method for Thanks again for your work on this :) |
Hey @cscherrer
Here's the implementation of the Gamma measure based on the version from Distributions.jl, with both standard parametrizations from Wikipedia.