Skip to content

Commit

Permalink
Swap out MakieCore for Requires (#577)
Browse files Browse the repository at this point in the history 
* Swap out MakieCore for Requires

* fix Aqua
  • Loading branch information
@jverzani
jverzani authored Jun 14, 2024
1 parent 2ddb628 commit 0c8c060
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 6 deletions.
7 changes: 5 additions & 2 deletions Project.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@ name = "Polynomials"
uuid = "f27b6e38-b328-58d1-80ce-0feddd5e7a45"
license = "MIT"
author = "JuliaMath"
version = "4.0.10"
version = "4.0.11"

[deps]
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
RecipesBase = "3cdcf5f2-1ef4-517c-9805-6587b60abb01"
Requires = "ae029012-a4dd-5104-9daa-d747884805df"
Setfield = "efcf1570-3423-57d1-acb7-fd33fddbac46"
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"

Expand All @@ -33,6 +34,7 @@ MakieCore = "0.6,0.7, 0.8"
MutableArithmetics = "1"
OffsetArrays = "1"
RecipesBase = "0.7, 0.8, 1"
Requires = "1.0"
Setfield = "1"
SparseArrays = "1.6"
SpecialFunctions = "1,2"
Expand All @@ -54,4 +56,5 @@ SpecialFunctions = "276daf66-3868-5448-9aa4-cd146d93841b"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[targets]
test = ["Aqua", "ChainRulesCore", "DualNumbers", "FFTW", "LinearAlgebra", "MakieCore", "MutableArithmetics", "SparseArrays", "OffsetArrays", "SpecialFunctions", "Test"]
test = ["Aqua", "ChainRulesCore", "DualNumbers", "FFTW", "LinearAlgebra",
"MutableArithmetics", "SparseArrays", "OffsetArrays", "SpecialFunctions", "Test"]
12 changes: 9 additions & 3 deletions src/Polynomials.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,16 @@ include("rational-functions/plot-recipes.jl")
include("legacy/misc.jl")
include("legacy/Poly.jl")

if !isdefined(Base, :get_extension)
include("../ext/PolynomialsMakieCoreExt.jl")
include("precompiles.jl")

@static if !isdefined(Base, :get_extension)
using Requires
end

include("precompiles.jl")
function __init__()
@static if !isdefined(Base, :get_extension)
@require MakieCore = "20f20a25-4f0e-4fdf-b5d1-57303727442b" include("../ext/PolynomialsMakieCoreExt.jl")
end
end

end # module
2 changes: 1 addition & 1 deletion test/aqua.jl
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
using Aqua

Aqua.test_all(Polynomials)
Aqua.test_all(Polynomials; stale_deps=(;ignore=[:Requires]))

2 comments on commit 0c8c060

@jverzani
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/109025

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v4.0.11 -m "<description of version>" 0c8c0608930cf9f0e860d8d66bf42417e573eb82
git push origin v4.0.11

Please sign in to comment.