Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omit pointless extra Newton iteration for λ #112

Merged
merged 1 commit into from
Jul 27, 2024
Merged

Conversation

stevengj
Copy link
Member

Since Newton iterations should be quadratically converging by the time we approach machine precision, the final iteration here is pointless (the next correction should be of order $\varepsilon^2$).

Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.55%. Comparing base (2e6fc15) to head (5863a04).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #112      +/-   ##
==========================================
- Coverage   98.56%   98.55%   -0.01%     
==========================================
  Files           7        7              
  Lines         696      694       -2     
==========================================
- Hits          686      684       -2     
  Misses         10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevengj stevengj merged commit 6ed7307 into master Jul 27, 2024
10 checks passed
@stevengj stevengj deleted the stevengj-patch-2 branch July 27, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant