Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ChainRulesCore v1 #335

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Support ChainRulesCore v1 #335

merged 1 commit into from
Jul 26, 2021

Conversation

oxinabox
Copy link
Contributor

@oxinabox oxinabox commented Jul 23, 2021

It's nice that this didn't break anything here.
It would be nice to get this merged relatively quickly, as SpecialFunctions is depended on by many packages and thus will block the ChainRulesCore v1 rollout

@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #335 (f8df1ba) into master (42bb273) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #335      +/-   ##
==========================================
- Coverage   92.61%   92.49%   -0.12%     
==========================================
  Files          12       12              
  Lines        2653     2653              
==========================================
- Hits         2457     2454       -3     
- Misses        196      199       +3     
Flag Coverage Δ
unittests 92.49% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/beta_inc.jl 89.61% <0.00%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42bb273...f8df1ba. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants