Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mpfr_lngamma for loggamma(::BigFloat) #351

Merged
merged 7 commits into from
Sep 30, 2021

Conversation

devmotion
Copy link
Member

This PR uses mpfr_lngamma for the implementation of loggamma(::BigFloat). Currently, loggamma(::BigFloat) is computed via logabsgamma(::BigFloat).

test/gamma.jl Outdated Show resolved Hide resolved
src/gamma.jl Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #351 (35c1cdd) into master (0c41812) will increase coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
+ Coverage   92.75%   93.06%   +0.31%     
==========================================
  Files          12       12              
  Lines        2706     2712       +6     
==========================================
+ Hits         2510     2524      +14     
+ Misses        196      188       -8     
Flag Coverage Δ
unittests 93.06% <100.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/gamma.jl 94.90% <100.00%> (+0.08%) ⬆️
src/beta_inc.jl 91.87% <0.00%> (+1.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c41812...35c1cdd. Read the comment docs.

test/gamma.jl Outdated Show resolved Hide resolved
@stevengj stevengj merged commit c0442c2 into JuliaMath:master Sep 30, 2021
@devmotion devmotion deleted the dw/lngamma branch September 30, 2021 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants