Add erfinv and erfcinv for Float16 and generalize logerfc and logerfcx
#372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #372 +/- ##
==========================================
- Coverage 94.95% 94.10% -0.85%
==========================================
Files 14 14
Lines 2914 2935 +21
==========================================
- Hits 2767 2762 -5
- Misses 147 173 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
devmotion
commented
Jun 30, 2023
|
@devmotion Is this good to merge? |
|
From my side yes but someone has to review it. |
|
Perhaps @oscardssmith ? |
oscardssmith
reviewed
May 7, 2024
oscardssmith
reviewed
May 7, 2024
oscardssmith
reviewed
May 7, 2024
oscardssmith
approved these changes
May 7, 2024
oscardssmith
added a commit
that referenced
this pull request
May 7, 2024
Followup to #372. This manages to remove a one of the branches by pushing the domain split further, and makes `erfcinv` use the better version I found for erfinv in the original PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says 🙂
I was a bit unsure if computations in
erfinvanderfcinvshould be performed withFloat32orFloat16since the coefficients in Blair's paper are not representable withFloat16.