Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MathConst was renamed Irrational (JuliaLang/julia#11922) #8

Merged
merged 1 commit into from
Dec 26, 2016
Merged

MathConst was renamed Irrational (JuliaLang/julia#11922) #8

merged 1 commit into from
Dec 26, 2016

Conversation

waldyrious
Copy link
Collaborator

Also some minor whitespace editing:

@waldyrious
Copy link
Collaborator Author

Hm, it could be interesting to activate Travis for this repo to automatically run the tests in all PRs. What do you think, @Aerlinger?

@lostanlen
Copy link

This looks good, cc @Aerlinger. Activating Travis is a good practice in general, although here it might overshoot the project a bit, whose functionality is simple and completed.

@waldyrious
Copy link
Collaborator Author

@Aerlinger ping

@waldyrious
Copy link
Collaborator Author

Hey @Aerlinger, I noticed you've been active again on github after a few months' hiatus. I'm pinging you to consider merging the PR, but additionally I'd like to propose helping out to maintain this package so that it doesn't depend on a single person. Would you add me as a collaborator? Another option is to move it to the @JuliaMath organization where others could chime in especially in getting quick fixes like this one merged.

@Aerlinger Aerlinger merged commit c3f2169 into JuliaMath:master Dec 26, 2016
@Aerlinger
Copy link
Collaborator

@waldyrious Thanks so much for the PR and sorry for the enormous delay. You've been added as a collaborator.

@waldyrious
Copy link
Collaborator Author

Thanks for the trust @Aerlinger :)

@waldyrious waldyrious deleted the mathconst-rename branch December 26, 2016 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants